This is the mail archive of the
mailing list for the binutils project.
Re: [PATCH] gold: fix some signed-unsigned comparison warnings
> Actually I overlooked entirely that you'd said that.
> But on reflection, I don't think it's really the right thing to do.
> It's not the natural type for sym_size, and changing its type that
> way is a much less obvious way to effect the change of the type of
> the expression in the lhs of that comparison, especially given that
> matching the rhs of the comparison is the only reason to use that type.
If it's not the natural type for sym_size, it's probably not the
natural type for Sized_elf_reloc_mapper::symtab_size_, either. It
seems to me that both should be the same type, and that type should
probably be section_size_type. But I fear the cascading effects of
making that change (unsigned pollution is every bit as frustrating as
const pollution). It's fine with me as committed.