This is the mail archive of the
mailing list for the binutils project.
Re: [PATCH 05/12] libiberty/ * configure: Add Microblaze PICFLAG
On 11 October 2012 03:58, Mike Frysinger <firstname.lastname@example.org> wrote:
> On Tuesday 09 October 2012 22:13:58 email@example.com wrote:
>> From: David Holsgrove <firstname.lastname@example.org>
>> Microblaze requires libiberty to be compiled with -fPIC
>> Signed-off-by: David Holsgrove <email@example.com>
>> Signed-off-by: Edgar E. Iglesias <firstname.lastname@example.org>
>> libiberty/ChangeLog | 4 ++++
>> libiberty/configure | 3 +++
> i'm afraid you've modified the wrong file. you need to update config/picflag.m4,
> send the patch to the gcc-patches mailing list, then once they accept it,
> merge the change back into the binutils tree, and then regenerate all the
> configure files that use that file.
> so NAK on this patch.
Thanks for the review. I'll update picflag.m4 for submission to gcc
and submit to binutils when its been included. I'll drop this patch
from my next version of the series.
Ralf, Andrew - thanks also, I'll be more specific with
microblaze*-*-linux-gnu rather than simply microblaze*.