This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, AArch64] fix the encoding of MOV immediate instructions in NDEBUG build


On 17/09/12 15:55, Tristan Gingold wrote:
> 
> On Sep 17, 2012, at 4:16 PM, Richard Earnshaw wrote:
> 
>> On 17/09/12 13:17, Yufeng Zhang wrote:
>>> Hi,
>>>
>>> This patch fixes an inappropriate assertion in AArch64 opcodes which 
>>> causes malfunction of gas in assembling MOV immediate instructions if 
>>> the tools are built with -DNDEBUG.
>>>
>>> The patch passes the regression test.
>>>
>>> OK to commit?
>>>
>>> Thanks,
>>> Yufeng
>>>
>>>
>>> opcodes/
>>>
>>> 2012-09-17  Yufeng Zhang  <yufeng.zhang@arm.com>
>>>
>>>          * aarch64-asm.c (aarch64_ins_imm_half): Remove 
>>> ATTRIBUTE_UNUSED from
>>>          the parameter 'inst'.
>>>          (aarch64_ins_addr_simm): Add ATTRIBUTE_UNUSED to the parameter 
>>> 'inst'.
>>>          (convert_mov_to_movewide): Change to assert (0) when
>>>          aarch64_wide_constant_p returns FALSE.
>>>
>>>
>>
>> OK.
>>
>> Tristan, this needs to go on the 2.23 branch as well please.
> 
> Fine with me.
> Do you take care of it, or do you prefer me to merge it ?
> (In the later case, would you like sending the binutils-cvs url of the commit message ?)
> 

Would you mind doing the honours?  The commit link is:

http://sourceware.org/ml/binutils-cvs/2012-09/msg00101.html



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]