This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Ping: [RFC,Patch,AVR]: ad PR13503: Add new relocs to TC_VALIDATE_FIX?

Denis Chertykov schrieb:
Georg-Johann Lay:
Just a ping for

Hi, in gas/config/tc-avr.h there is the following comment

/* We don't want gas to fixup the following program memory related
   We will need them in case that we want to do linker relaxation.
   We could in principle keep these fixups in gas when not relaxing.
   However, there is no serious performance penilty when making the linker
   make the fixup work.  Check also that fx_addsy is not NULL, in order to
   sure that the fixup refers to some sort of lable.  */

PR13503 introduced new relocs that are not mentioned in TC_VALIDATE_FIX.

The attached patch adds the new BFD_RELOC_AVR_8_LO, BFD_RELOC_AVR_8_HI,
BFD_RELOC_AVR_8_HLO to that exclude list.

I cannot say if these new relocs need to be handled there, if the must
be handled there or must *not* be handled there.  I just noticed that
the new relocs are missing there, but no clue if that's good or bad or
simply does not matter...

Thus please review this patch.  And in the case it is actually needed,
please apply it.

gas/ PR 13503 * config/tc-avr.h (TC_VALIDATE_FIX): Skip: BFD_RELOC_AVR_8_LO, BFD_RELOC_AVR_8_HI, BFD_RELOC_AVR_8_HLO.

Seems right, but I don't remember some BFD nuances.


If it is in order, please don't forget to install it.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]