This is the mail archive of the
mailing list for the binutils project.
Re: Committed; fix PR gas/14521, missing renumber_sections for MMIX. Also, RFC.
- From: Alan Modra <amodra at gmail dot com>
- To: Hans-Peter Nilsson <hp at bitrange dot com>
- Cc: binutils at sourceware dot org
- Date: Sun, 2 Sep 2012 14:16:59 +0930
- Subject: Re: Committed; fix PR gas/14521, missing renumber_sections for MMIX. Also, RFC.
- References: <alpine.BSF.email@example.com>
On Sat, Sep 01, 2012 at 02:14:21PM -0400, Hans-Peter Nilsson wrote:
> seriously, I'd like this unkludged. At the very least I suggest
> renumber_sections can be globalized and renamed gas_renumber_sections.
> Would that be ok? Maybe we can do better, like moving the
> renumber_sections call in write.c to after tc_frob_file_before_fix and
> md_post_relax_hook, assuming valid section numbers aren't needed
> before that for some other target. It'd have to be a target-specific
> need or else the Xtensa and MMIX kludges will fail for some cases.
Moving the renumber_sections call may affect section symbols. I'm not
sure, but that is something you'd want to check.
> I also noticed that the .section call doesn't modify the existing
> .text section but instead causes an *extra* .text section, one with
> the AXG flags. Should that really happen? (Same for cris-elf and mmix.)
Yes. Group sections should not be merged with non-group sections (or
with group sections belonging to a different group) even though they
have the same name.
Australia Development Lab, IBM