This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] S/390: Fix two issues with the IFUNC optimized mem* routines
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Richard Henderson <rth at twiddle dot net>
- Cc: Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>, David Miller <davem at davemloft dot net>, aj at suse dot com, libc-alpha at sourceware dot org, Binutils <binutils at sourceware dot org>
- Date: Fri, 31 Aug 2012 11:09:08 -0700
- Subject: Re: [PATCH] S/390: Fix two issues with the IFUNC optimized mem* routines
- References: <503E009B.3080302@linux.vnet.ibm.com> <CAMe9rOrmiF3VZOBNvEbMV5jFNog1-_EoPoT9rHTUQFsANaSD8w@mail.gmail.com> <503E3930.5040603@linux.vnet.ibm.com> <20120829.125208.824114683359549094.davem@davemloft.net> <503F14A3.8070801@linux.vnet.ibm.com> <CAMe9rOozW=4q_a=nmNvbZhsXooRZ4opvTTNtq2WHcGSSd2ONOw@mail.gmail.com> <CAMe9rOpc7KHMXk8xrQV3p2fAn-uTWZJ91R6k=DbCXENs43Kemw@mail.gmail.com> <5040CCC6.4030809@twiddle.net>
On Fri, Aug 31, 2012 at 7:40 AM, Richard Henderson <rth@twiddle.net> wrote:
> On 08/30/2012 06:02 PM, H.J. Lu wrote:
>> @@ -3470,6 +3470,25 @@ elf_i386_relocate_section (bfd *output_bfd,
>
> Don't do these sorts of things in relocate_section.
>
> Do them in relax_section where you still have time
> to remove the got entry if it becomes unused.
>
This is an excellent idea. But relax_section is too late for
x86 and x86-64. I need to do it in size_dynamic_sections
so that we can get proper GOT entries.
--
H.J.