This is the mail archive of the
mailing list for the binutils project.
Re: [GOLD] tidy powerpc Glink_sym_ent
- From: Ian Lance Taylor <iant at google dot com>
- To: binutils at sourceware dot org
- Date: Mon, 13 Aug 2012 09:02:21 -0700
- Subject: Re: [GOLD] tidy powerpc Glink_sym_ent
- References: <20120813141126.GB3947@bubble.grove.modra.org>
On Mon, Aug 13, 2012 at 7:11 AM, Alan Modra <firstname.lastname@example.org> wrote:
> * powerpc.cc (Powerpc_relobj::set_got2_shndx): Delete.
> (Powerpc_relobj::do_find_special_sections): Don't use set_got2_shndx.
> (Output_data_glink::add_entry,find_entry): Remove shndx param.
> (class Glink_sym_ent): Rename from struct Glink_sym_ent. Remove
> all references to shndx_. Handle special case for R_PPC_PLTREL24
> (class Glink_sym_ent_hash): Rename from struct Glink_sym_ent_hash.
> (Output_data_glink::do_write): Retrieve got2_shdnx from object.
> (Target_powerpc::make_plt_entry): Don't special case R_PPC_PLTREL24
> (Target_powerpc::Scan::global): Nor on make_plt_entry call.
> (Target_powerpc::Relocate::relocate): Nor on glink->find_entry call.
This is OK.
In general, please feel free to commit changes to gold/powerpc.cc
without prior review. I would prefer to review patches to the other
files in gold, though. Of course I'm happy to look at any patch to
powerpc.cc if you aren't sure about it.