This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] MIPS: Enable NewABI testing for all Linux targets


> I'm ambivalent about this change.  It seems to me that while
> it's running more tests, it's actually giving less coverage.
> It's forcing more and more of the GNU/Linux tests to act in the same way
> as mips64-linux-gnu, so fewer of the mipsisa64-linux-gnu tests (say) are
> actually testing the way that mipsisa64-linux-gnu itself will be used.
> I.e. -n64, -n32 and -32 are commonplace options for all mips*-linux-gnu,
> but -mabi=from-abi is either redundant (for the base configurations)
> or incompatible with the target libraries, and so unlikely to be used.

 I can see your point, in fact I've been wondering how to enable these 
tests for configurations that default to o32, but treat n32/n64 as equally 
important options, without hardcoding the ISA selection -- 
mipsisa32*-linux regressions came as a nasty surprise to me while testing 
this change as I don't use such targets.

 It seems that it has become more and more difficult to figure out the 
minimum set of options required to switch between the ABIs -- perhaps 
these should be determined at the test suite run time.  What do you think?

> That's just for the record though.  The OK still stands.

 Can you comment on my concerns about config.bfd too?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]