This is the mail archive of the
mailing list for the binutils project.
Re: [PATCH] MIPS: 32-bit microMIPS DSP ASE support
On Wed, 1 Aug 2012, Alan Modra wrote:
> > I didn't run `quilt refresh' to regenerate the patch, sorry about that --
> > you can see I meant to drop the "l" modifier and code was indeed tested
> > with that update already made. I also used an outdated version of
> > ChangeLog, I'll fix that up as follows -- what's the convention for CVS
> > log entries for ChangeLog corrections?
> "correct changelog" would do. I don't think it matters very much.
OK, I'm being over-cautious, especially as...
> > --- opcodes/ChangeLog 1 Aug 2012 00:41:34 -0000 1.1837
> > +++ opcodes/ChangeLog 1 Aug 2012 01:21:44 -0000
> > @@ -19,7 +19,7 @@
> > (DSP_VOLA): Likewise.
> > (D32, D33): Likewise.
> > (micromips_opcodes): Add DSP ASE instructions.
> > - * mips-dis.c (print_insn_micromips) <'2', '3'>: New cases.
> > + * micromips-dis.c (print_insn_micromips) <'2', '3'>: New cases.
> Not this one! I already fixed it. micromips-dis.c doesn't exist.
... I must be obviously lacking some sleep. Thanks for catching this.
It looks like I've got two ChangeLog records neither of which I made
completely correct, sigh...