This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: PR gas/14315: Inconsistent .weak and .comm directives


I think this is probably all that is necessary.  I'm running some
tests and will commit this if they all pass.  Please commit the
testsuite addition after I commit this fix.

	PR gas/14315
	* gas/config/obj-elf.c (obj_elf_weak): Don't set local.

Index: gas/config/obj-elf.c
===================================================================
RCS file: /cvs/src/src/gas/config/obj-elf.c,v
retrieving revision 1.146
diff -u -p -r1.146 obj-elf.c
--- gas/config/obj-elf.c	19 May 2012 10:36:32 -0000	1.146
+++ gas/config/obj-elf.c	30 Jun 2012 03:21:34 -0000
@@ -447,7 +447,6 @@ obj_elf_weak (int ignore ATTRIBUTE_UNUSE
       symbolP = get_sym_from_input_line_and_check ();
       c = *input_line_pointer;
       S_SET_WEAK (symbolP);
-      symbol_get_obj (symbolP)->local = 1;
       if (c == ',')
 	{
 	  input_line_pointer++;

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]