This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: PR ld/14156: -sort-section=alignment trashes init/fini sections, and anything similar

On Wed, Jun 27, 2012 at 10:30:11AM -0700, H.J. Lu wrote:
>  	    case lang_wild_statement_enum:
>  	      sec = s->wild_statement.section_list;
> -	      for (sec = s->wild_statement.section_list; sec != NULL;
> -		   sec = sec->next)
> +	      /* Don't sort .init/.fini sections.  */
> +	      if (sec == NULL
> +		  || strcmp (sec->, ".init") == 0
> +		  || strcmp (sec->, ".fini") == 0)
> +		break;
> +	      for (; sec != NULL; sec = sec->next)
>  		{
>  		  switch (sec->spec.sorted)
>  		    {

If we are going to hard code .init and .fini names (and we do that
elsewhere) I think it would be better to disable the sorting when
looking at the output_section_statement rather than the

Hmm, even better, inplement a SORT_NONE script keyword to extend our
current list of sorting keywords, SORT_BY_NAME, SORT_BY_ALIGNMENT and
SORT_BY_INIT_PRIORITY.  SORT_NONE does the obvious, overriding
--sort-section=name and --sort-section=alignment.

Alan Modra
Australia Development Lab, IBM

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]