This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: fixlets to dwarf-mode.el

>>>>> "Tom" == Tom Tromey <> writes:

Tom> This patch fixes a few minor issues in dwarf-mode.el.
Tom> First, it adds a trailing comment.  This lets you install the file using
Tom> package.el, e.g., M-x package-install-file.

Here's an update which also fixes a typo in an autoload cookie.
This typo prevents M-x dwarf-browse from being visible in Emacs when the
package is activated; it is only available after the package is loaded.



2012-06-12  Tom Tromey  <>

	* dwarf-mode.el: Add final comment.  Bump version.
	(dwarf-insert-substructure-button): Use string-to-number.
	(dwarf-browse): Fix autoload cookie.

Index: dwarf-mode.el
RCS file: /cvs/src/src/binutils/dwarf-mode.el,v
retrieving revision 1.2
diff -u -r1.2 dwarf-mode.el
--- dwarf-mode.el	16 Jun 2011 16:39:23 -0000	1.2
+++ dwarf-mode.el	12 Jun 2012 16:59:04 -0000
@@ -1,6 +1,6 @@
 ;;; dwarf-mode.el --- Browser for DWARF information.
-;; Version: 1.0
+;; Version: 1.1
 ;; This file is not part of GNU Emacs, but is distributed under the
 ;; same terms:
@@ -56,7 +56,7 @@
   (unless (looking-at "^ <\\([0-9]+\\)>")
     (error "Unrecognized line."))
-  (let ((new-depth (1+ (string-to-int (match-string 1)))))
+  (let ((new-depth (1+ (string-to-number (match-string 1)))))
     (dwarf-do-insert-substructure new-depth die)))
 (defun dwarf-insert-substructure (arg)
@@ -152,7 +152,7 @@
 (define-key dwarf-mode-map [(control ?m)] #'dwarf-insert-substructure)
 (defun dwarf-browse (file)
   "Invoke `objdump' and put output into a `dwarf-mode' buffer.
 This is the main interface to `dwarf-mode'."
@@ -165,3 +165,5 @@
 (provide 'dwarf-mode)
+;;; dwarf-mode.el ends here

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]