This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Reindent assign_file_positions_for_non_load_sections


On Mon, Jun 11, 2012 at 10:12 AM, David Daney <ddaney.cavm@gmail.com> wrote:
> On 06/11/2012 09:50 AM, H.J. Lu wrote:
>>
>> On Mon, Jun 11, 2012 at 09:44:51AM -0700, H.J. Lu wrote:
>>>
>>> Hi,
>>>
>>> I checked in this patch to reindent _bfd_elf_map_sections_to_segments.
>>>
> [...]
>
>> diff --git a/patches/ChangeLog b/patches/ChangeLog
>> index 2e62b52..3660f41 100644
>> --- a/patches/ChangeLog
>> +++ b/patches/ChangeLog
>> @@ -1,3 +1,9 @@
>> +2012-06-10 ?H.J. Lu<hjl.tools@gmail.com>
>> +
>> + ? ? ? * binutils-pr14215.patch: New.
>> + ? ? ? * binutils-pr14207.patch: Likewise.
>> + ? ? ? * README: Apply them.
>> +
>
>
> Is there a reason not to just say you re-indented here?
>
> I think adding a level of indirection in the ChangeLog it not a good thing.
>

Oops.  They don't belong in the patch.  The
checked in one is OK:

http://sourceware.org/ml/binutils-cvs/2012-06/msg00049.html


-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]