This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH/MIPS] Fix Branches with a constant offset


Hi,
  After:
2011-04-20  Catherine Moore  <clm@codesourcery.com>
            David Ung <davidu@mips.com>..
        * config/mips.c (mips_cl_insn): Add new field complete_p
...
        (append_insn): Move O_constant expression handling.

branches with a constant expression are broken by adding a relocation to them.
The relocation is totally wrong as it is saying it is an absolute
address while what we have really is an offset.

This patch fixes the issue with how complete_p is handled for
O_constant expression handling just like it was handled before this
patch.

OK?  Tested on mips64-linux-gnu with no regressions.

Thanks,
Andrew Pinski

ChangeLog:
* config/tc-mips.c (append_insn): Fix O_constant handling.

testsuite/ChangeLog:
* gas/mips/branch-misc-5.d: New file.
* gas/mips/branch-misc-5.s: New file.
* gas/mips/micromips@branch-misc-5.d: New file.
* gas/mips/mips.exp: Run branch-misc-5 also.

Attachment: fixconstantbranches.diff.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]