This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Patch: fixlets to dwarf-mode.el


This patch fixes a few minor issues in dwarf-mode.el.

First, it adds a trailing comment.  This lets you install the file using
package.el, e.g., M-x package-install-file.

Next, it fixes a byte compilation warning found when doing this.

Finally, it bumps the version number, which I think is a nice thing to
do whenever modifying it.  In most cases this is needed so that
package.el will install the updated version; in this particular case
that could be avoided (since one cannot install the unpatched version),
but I felt it was a good practice to get into.

Ok?

Tom

2012-06-05  Tom Tromey  <tromey@redhat.com>

	* dwarf-mode.el: Add final comment.  Bump version.
	(dwarf-insert-substructure-button): Use string-to-number.

Index: dwarf-mode.el
===================================================================
RCS file: /cvs/src/src/binutils/dwarf-mode.el,v
retrieving revision 1.2
diff -u -r1.2 dwarf-mode.el
--- dwarf-mode.el	16 Jun 2011 16:39:23 -0000	1.2
+++ dwarf-mode.el	5 Jun 2012 20:40:34 -0000
@@ -1,6 +1,6 @@
 ;;; dwarf-mode.el --- Browser for DWARF information.
 
-;; Version: 1.0
+;; Version: 1.1
 
 ;; This file is not part of GNU Emacs, but is distributed under the
 ;; same terms:
@@ -56,7 +56,7 @@
   (beginning-of-line)
   (unless (looking-at "^ <\\([0-9]+\\)>")
     (error "Unrecognized line."))
-  (let ((new-depth (1+ (string-to-int (match-string 1)))))
+  (let ((new-depth (1+ (string-to-number (match-string 1)))))
     (dwarf-do-insert-substructure new-depth die)))
 
 (defun dwarf-insert-substructure (arg)
@@ -165,3 +165,5 @@
     (dwarf-do-refresh)))
 
 (provide 'dwarf-mode)
+
+;;; dwarf-mode.el ends here


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]