This is the mail archive of the
mailing list for the binutils project.
Re: [Patch] Improve dump of xdata/pdata for Windows x86
On Jun 5, 2012, at 5:32 PM, Kai Tietz wrote:
> Hello Tristan,
> I was first confused by the subject-line :)
Oops, sorry for the typo: it should be x64.
> 2012/6/5 Tristan Gingold <firstname.lastname@example.org>:
>> while working on Windows 64 SEH info, I think it was worth improving the output of 'objdump -p':
>> * exception handler and chained unwind info are now displayed
>> * for chained pdata entries, the corresponding unwind info rva is now printed.
>> I also made the corresponding cleanup changes in include/coff/pe.h after checking by git grep that the fields deleted weren't used.
>> No regressions while cross-checking on Darwin for x86_64-pc-mingw32.
>> Ok for trunk ?
> The patch looks ok for me, but I can't approve it. The fields you are
> removing aren't used, so we can remove them. In the intial patch
> there were support of displaying scoped-exception-defintiion generated
> by msc by using those fields. As we don't need them it is ok IMHO to
> remove them.
Ok. Thanks for the historical note.
> I add Nick for review, as I assume that Dave might be a bit inactive right now.