This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] bfd: Use size_t for length argument totarget_read_memory function passed into bfd_elf_bfd_from_remote_memory


On Mon, 28 May 2012 13:03:13 +0200, Alan Modra wrote:
> Since Jan has already given the OK, and these functions are only used
> by gdb, binutils maintainers hardly need to look at the patch.  OK
> anyway, but please fix the ChangeLog

I would like to make the function at least formally really working with the new
types, therefore the patch below.

OK from me for the gdb/ part.


Thanks,
Jan


bfd/
2012-05-28  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* elfcode.h (NAME(_bfd_elf,bfd_from_remote_memory)): Make
	contents_size type bfd_size_type.

diff --git a/bfd/elfcode.h b/bfd/elfcode.h
index c985c63..1ff3f07 100644
--- a/bfd/elfcode.h
+++ b/bfd/elfcode.h
@@ -1623,7 +1623,7 @@ NAME(_bfd_elf,bfd_from_remote_memory)
   Elf_Internal_Phdr *i_phdrs, *last_phdr;
   bfd *nbfd;
   struct bfd_in_memory *bim;
-  int contents_size;
+  bfd_size_type contents_size;
   bfd_byte *contents;
   int err;
   unsigned int i;


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]