This is the mail archive of the
mailing list for the binutils project.
Re: gold patch committed: Build fixes for clang
- From: Andrew Pinski <pinskia at gmail dot com>
- To: Ian Lance Taylor <iant at google dot com>
- Cc: binutils at sourceware dot org
- Date: Wed, 25 Apr 2012 17:31:52 -0700
- Subject: Re: gold patch committed: Build fixes for clang
- References: <firstname.lastname@example.org>
On Wed, Apr 25, 2012 at 5:07 PM, Ian Lance Taylor <email@example.com> wrote:
> I got a report of some warnings building gold with clang. ÂThis patch
> fixes them. ÂCommitted to mainline.
These fixes are not really needed for standard C++ compiler.
Since struct and class are interchangeable there.
I think it was a bad decision on clang's part to say they are different.
Though can you figure out why GCC does not warn/error out about the
> 2012-04-25 ÂIan Lance Taylor Â<firstname.lastname@example.org>
> Â Â Â Â* arm.cc (Target_arm::do_is_defined_by_abi): Make sym a const
> Â Â Â Âpointer.
> Â Â Â Â(Stub_addend_reader::operator()): Declare Arm_relocate_functions
> Â Â Â Âas a class, not a struct.
> Â Â Â Â(Target_arm::scan_span_for_cortex_a8_erratum): Likewise.
> Â Â Â Â(Target_arm::apply_cortex_a8_workaround): Likewise.
> Â Â Â Â* gc.h: Declare Reloc_types as a struct, not a class.
> Â Â Â Â* object.h: Declare Symbols_data as a struct.
> Â Â Â Â* reloc.h: Declare Read_relocs_data as a struct.
> Â Â Â Â* target.h: Declare Relocate_info as a struct.