This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: Add support for XGATE CPU and update M68HCS12X port


(Extracted from Sean's patch.)
--------
diff --git src/opcodes/m68hc11-opc.c src/opcodes/m68hc11-opc.c
index ac6259d..b66ef6a 100644
--- src/opcodes/m68hc11-opc.c
+++ src/opcodes/m68hc11-opc.c
@@ -2,6 +2,8 @@
    Copyright 1999, 2000, 2002, 2005, 2007 Free Software Foundation,
Inc.
    Written by Stephane Carrez (stcarrez@nerim.fr)
 
+   S12X updates by Sean Keys(skeys@ipdatasys.com)
+
    This file is part of the GNU opcodes library.
--------

I disagree, the changes appear to be mostly my work, but with your name
at the top.
There are tell-tale identical comments and the mistake I made with
rorx/rory is there too.

You patch does not appear to include support for the new extended modes
of some of the S12X opcodes in tc-m68hc11.c (movb,movw,sex)

I haven't reviewed it any further than that.

regards

James

PS. I thought we had agreed that we would collaborate and you would help
test my XGATE patches instead of submitting 'rival' work?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]