This is the mail archive of the
mailing list for the binutils project.
Re: [gold] PATCH: Initial x32 support
- From: Ian Lance Taylor <iant at google dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Cary Coutant <ccoutant at google dot com>, binutils at sourceware dot org
- Date: Fri, 06 Jan 2012 15:37:48 -0800
- Subject: Re: [gold] PATCH: Initial x32 support
- References: <CAMe9rOpDMLZEJ-EQXrwqHjMOJMYzOkeHbuSQ0xaoGQnA_GXjCg@mail.gmail.com>
"H.J. Lu" <firstname.lastname@example.org> writes:
> 2012-01-04 H.J. Lu <email@example.com>
> * x86_64.cc: Initial support for x32.
> local_reloc_may_be_function_pointer(Symbol_table* symtab, Layout* layout,
> Target_x86_64* target,
When there is a parameter of type Target_x86_64, I think it is clearer
with your change to write Target_x86_64<size>. This appears in several
places, both in declarations and in definitions. Otherwise the name is
used both as a template and not, which I think can be confusing.
> +Target_x86_64<size>::Relocate::relocate(const Relocate_info<size, false>* relinfo,
When a function runs past 80 columns as this one does, please start the
parameters on the next line and indent all of them by four spaces. See,
e.g., Target_x86_64::reserve_local_got_entry. This appears in various
This patch is OK if you fix those minor issues.