This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gold] PATCH: Initial x32 support


On Wed, Jan 4, 2012 at 2:48 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Tue, Jan 3, 2012 at 4:25 PM, Cary Coutant <ccoutant@google.com> wrote:
>>>> 2012-01-03 ?Cary Coutant ?<ccoutant@google.com>
>>>>
>>>> ? ? ? * gold/incremental.cc (Sized_incremental_binary::do_process_got_plt):
>>>> ? ? ? Use abstract base class for GOT.
>>>> ? ? ? * gold/output.h (class Output_data_got_base): New abstract base class.
>>>> ? ? ? (class Output_data_got): Derive from new base class, adjust ctors.
>>>> ? ? ? (Output_data_got::reserve_slot): Make virtual; rename to
>>>> ? ? ? do_reserve_slot; Adjust callers.
>>>> ? ? ? * gold/target.h (Sized_target::init_got_plt_for_update): Return
>>>> ? ? ? pointer to abstract base class.
>>>> ? ? ? * gold/x86_64.cc (Target_x86_64::init_got_plt_for_update): Likewise.
>>>>
>>>> + ?// Reserve a slot in the GOT.
>>>> + ?void
>>>> + ?reserve_slot(unsigned int i)
>>>> + ?{ this->do_reserve_slot(i); }
>>>
>>> Have the comment explain the meaning of the parameter 'i'.
>>>
>>> This is OK with that change.
>>
>> Done, and committed. Thanks.
>>
>> HJ, please let me know if this solved your problem.
>>
>
> It works great. ?Here is the initial x32 support in gold.
> I just added template<int size> to replace <64>. It can
> generate a simple x32 binary. ?OK to install?
>
> I have more follow up patches to fix other issues.
>
> Thanks.
>
>
> --
> H.J.
> ---
> 2012-01-04 ?H.J. Lu ?<hongjiu.lu@intel.com>
>
> ? ? ? ?* x86_64.cc: Initial support for x32.

Ping

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]