This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Patch Darwin/testsuite/objcopy] Do not try to run the copy-2/3.d tests for darwin.
- From: Tristan Gingold <gingold at adacore dot com>
- To: Iain Sandoe <developer at sandoe-acoustics dot co dot uk>
- Cc: binutils Development <binutils at sourceware dot org>
- Date: Mon, 2 Jan 2012 12:27:35 +0100
- Subject: Re: [Patch Darwin/testsuite/objcopy] Do not try to run the copy-2/3.d tests for darwin.
- References: <91B188DC-F39A-4AE5-9B23-8F0ECF1EF160@sandoe-acoustics.co.uk>
On Dec 30, 2011, at 10:07 PM, Iain Sandoe wrote:
> trying to work through the test-suite to find which fails represent stuff we still need to implement (and which are noise).
>
> AFAICS, these two tests are not applicable to mach-o, certainly as they stand (they would require a different .s file to work).
Ok with me. Need perhaps a confirmation from a global maintainer.
Tristan.
>
> OK?
> Iain
>
> binutils/testsuite:
>
> * binutils-all/copy-2.d: Do not run for Darwin.
> * binutils-all/copy-3.d: Likewise.
>
> binutils/testsuite/binutils-all/copy-2.d | 2 +-
> binutils/testsuite/binutils-all/copy-3.d | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/binutils/testsuite/binutils-all/copy-2.d b/binutils/testsuite/binutils-all/copy-2.d
> index 5636ff6..4640709 100644
> --- a/binutils/testsuite/binutils-all/copy-2.d
> +++ b/binutils/testsuite/binutils-all/copy-2.d
> @@ -3,7 +3,7 @@
> #objcopy: --set-section-flags foo=contents,alloc,load,code
> #name: copy with setting section flags 2
> #source: copytest.s
> -#not-target: *-*-*aout *-*-aix* h8300-*-* hppa*-*-hpux* m68k-*-netbsd m68k-*-openbsd* mips-sony-bsd* mips-*-ultrix* mips-*-osf* mips-*-ecoff* mips-*-irix mips-*-irix[2-4] mips-*-riscos* ns32k-*-netbsd
> +#not-target: *-*-*aout *-*-aix* h8300-*-* hppa*-*-hpux* m68k-*-netbsd m68k-*-openbsd* mips-sony-bsd* mips-*-ultrix* mips-*-osf* mips-*-ecoff* mips-*-irix mips-*-irix[2-4] mips-*-riscos* ns32k-*-netbsd *-*-darwin*
> # Note - we use copytest.s and a section named "foo" rather
> # than .text because for some file formats (eg PE) the .text
> # section has a fixed set of flags and these cannot be changed.
> diff --git a/binutils/testsuite/binutils-all/copy-3.d b/binutils/testsuite/binutils-all/copy-3.d
> index 551517c..2d42ce8 100644
> --- a/binutils/testsuite/binutils-all/copy-3.d
> +++ b/binutils/testsuite/binutils-all/copy-3.d
> @@ -3,7 +3,7 @@
> #objcopy: --set-section-flags .text=alloc,data
> #name: copy with setting section flags 3
> #source: bintest.s
> -#not-target: *-*-*aout *-*-*pe *-*-*coff hppa*-*-hpux* i*86-*-cygwin* i*86-*-mingw32* m68k-*-netbsd m68k-*-openbsd* ns32k-*-netbsd x86_64-*-mingw*
> +#not-target: *-*-*aout *-*-*pe *-*-*coff hppa*-*-hpux* i*86-*-cygwin* i*86-*-mingw32* m68k-*-netbsd m68k-*-openbsd* ns32k-*-netbsd x86_64-*-mingw* *-*-darwin*
> # The .text # section in PE/COFF has a fixed set of flags and these
> # cannot be changed. We skip it for them.
>
>