This is the mail archive of the
mailing list for the binutils project.
Re: [PATCH 1/1] x86: Add process memory layout to coredump file
- From: t cheney <cdmalord at gmail dot com>
- To: Al Viro <viro at zeniv dot linux dot org dot uk>
- Cc: linux-kernel at vger dot kernel dot org, linux-fsdevel at vger dot kernel dot org, gdb-patches at sourceware dot org, binutils at sourceware dot org
- Date: Sun, 18 Dec 2011 20:37:55 +0800
- Subject: Re: [PATCH 1/1] x86: Add process memory layout to coredump file
- References: <CAE04G=Bu4WnU9SYU9u3-ap6OrBEjWONK8TA8bYBy5OSCCzzDqg@mail.gmail.com> <20111214211652.GO2203@ZenIV.linux.org.uk>
On 12/15/11, Al Viro <firstname.lastname@example.org> wrote:
> On Sat, Dec 10, 2011 at 10:37:02PM +0800, t cheney wrote:
>> This patch just add memory layout(same as /proc/pid/maps) to
>> coredump file. The layout is appended to corenote segment with
>> flag NT_MAPS=7.
>> + len = sprintf(buf, "%08lx-%08lx %c%c%c%c %08llx %02x:%02x %lu",
>> + start,
>> + end,
>> + flags & VM_READ ? 'r' : '-',
>> + flags & VM_WRITE ? 'w' : '-',
>> + flags & VM_EXEC ? 'x' : '-',
>> + flags & VM_MAYSHARE ? 's' : 'p',
>> + pgoff,
>> + MAJOR(dev), MINOR(dev), ino);
> Device numbers may be wider than 16 bits.
Yes, it should be:
len = sprintf(buf, "%08lx-%08lx %c%c%c%c %08llx %03x:%05x %lu",
and corresponding change from 25 to 29 in function pad_spaces:
static int pad_spaces(char *p, int len)
len = 29 + sizeof(void *) * 6 - len;
>> + p = d_path(&vma->vm_file->f_path, s, maps_size-1);
> What if somebody renames the file (or, better yet, its parent directory)
> between two calls of that thing?
Yes, function core_handle_maps is called twice, first one just calculate size,
second one write maps into coredump file. If the pathname is changed,
the size may changed too.
If the new size is less than or same as origin, all maps string is
written to file.
If the new size is more than origin, just part is written to file,
the rest is ignored.