This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[RFA/ARM] Fix recognition of Neon instruction shapes.

From: Matthew Gretton-Dann <matthew dot gretton-dann at arm dot com>
To: "binutils at sourceware dot org" <binutils at sourceware dot org>
Cc: Richard Earnshaw <Richard dot Earnshaw at arm dot com>
Date: Wed, 07 Dec 2011 13:56:37 +0000
Subject: [RFA/ARM] Fix recognition of Neon instruction shapes.

The attached patch fixes how Neon instruction shapes are recognised.

Currently neon_select_shape will recognise the following instruction as
NS_DF instead of rejecting it:
   vcvt.f64.s32 d0, s0, #11

This is because the recognition checks that the first operands match the
'shape' for NS_DF, but doesn't check that there are no operands
following.

Tested on arm-none-eabi. This shows regressions which are fixed by the previously posted patch at http://sourceware.org/ml/binutils/2011-12/msg00079.html.

OK?

gas/ChangeLog:

2011-12-07 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>

	* config/tc-arm.c (ARM_IT_MAX_OPERANDS): New define.
	(arm_it): Use ARM_IT_MAX_OPERANDS.
	(neon_select_shape): Ensure we have matched all	operands.

gas/testsuite/ChangeLog:

2011-12-07 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>

	* gas/arm/neon-suffix-bad.l: Add testcase.
	* gas/arm/neon-suffix-bad.s: Likewise.

Thanks,

Matt

--
Matthew Gretton-Dann
Principal Engineer, PD Software - Tools, ARM Ltd

Attachment: 2-PATCH-ARM-Fix-recognition-of-Neon-instruction-shapes.txt
Description: Text document

Follow-Ups:
- Re: [RFA/ARM] Fix recognition of Neon instruction shapes.
  - From: Richard Earnshaw

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]