This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][GOLD] Fix just_symbols failure on ARM.


Thanks.  I've checked the code in.  I think we can create an object
factory class to build regular and dynamic objects and have the
duplicated code pushed back into the parent Target class.  Then the
ARM backend can subclass the object factory to provide wrapped
objects.  This will be done if I have time :-)

-Doug

On Fri, Nov 11, 2011 at 1:41 PM, Ian Lance Taylor <iant@google.com> wrote:
> "Doug Kwan (éæå)" <dougkwan@google.com> writes:
>
>> 2011-11-11 ÂDoug Kwan Â<dougkwan@google.com>
>>
>> Â Â Â Â * arm.cc (Target_arm::do_make_elf_object): Allow executable also
>> Â Â Â Â if --just-symbols is given.
>
> This is OK.
>
> Thanks.
>
> What happened, of course, is that the duplicated code was changed in one
> place but not in the other. ÂExtra bonus points if you can figure out to
> eliminate the code duplication so that this doesn't happen again.
>
> Ian
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]