This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH] MIPS/GAS: Fix MCU ASE's availability with the microMIPS ASE
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: <binutils at sourceware dot org>
- Cc: Richard Sandiford <rdsandiford at googlemail dot com>
- Date: Mon, 24 Oct 2011 22:36:25 +0100
- Subject: [PATCH] MIPS/GAS: Fix MCU ASE's availability with the microMIPS ASE
Hi,
The MCU ASE is always an available (though not necessarily present)
option for processors that support the microMIPS ASE, there's no need to
further qualify it with the ISA level.
Here's a change to fix this, removing the requirement to add
"-march=mips32r2" or "-march=mips64r2" alongside "-mmicromips -mmcu" to
avoid an "ISA does not support MCU ASE" error message.
Regression-tested successfully, for the mips-linux-gnu and mips-sde-elf
targets. OK to apply?
2011-10-24 Maciej W. Rozycki <macro@codesourcery.com>
gas/
* config/tc-mips.c (ISA_SUPPORTS_MCU_ASE): Also set if microMIPS
mode.
Hmm, it looks like we missed similar ChangeLog entries for ISA_HAS_ROR,
etc. with the main microMIPS change, oh well.
Maciej
binutils-umips-mcu-fix.diff
Index: binutils-fsf-trunk-quilt/gas/config/tc-mips.c
===================================================================
--- binutils-fsf-trunk-quilt.orig/gas/config/tc-mips.c 2011-10-24 22:15:38.355861017 +0100
+++ binutils-fsf-trunk-quilt/gas/config/tc-mips.c 2011-10-24 22:15:38.555969862 +0100
@@ -370,7 +370,8 @@ static int file_ase_mt;
|| mips_opts.isa == ISA_MIPS64R2)
#define ISA_SUPPORTS_MCU_ASE (mips_opts.isa == ISA_MIPS32R2 \
- || mips_opts.isa == ISA_MIPS64R2)
+ || mips_opts.isa == ISA_MIPS64R2 \
+ || mips_opts.micromips)
/* The argument of the -march= flag. The architecture we are assembling. */
static int file_mips_arch = CPU_UNKNOWN;