This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix bug in plugin section ordering infrastructure when layout is deferred.


Sorry for the typos. Patch updated.

Thanks,
-Sri.

On Thu, Sep 29, 2011 at 11:25 AM, Cary Coutant <ccoutant@google.com> wrote:
>> All done. Patch attached.
>
> In gold.cc...
> + ? ? ?for (Layout::Section_list::const_iterator p =
> layout->section_list().begin();
>
> This line is too long.
>
> + ? ? ?&& !parameters->options().section_ordering_file ())
>
> Sorry, I missed a space-before-paren in the last review.
>
> In plugin.cc...
> + ?std::map<Section_id, unsigned int>* order_map
> + ? ?= layout->get_section_order_map ();
>
> Another one.
>
> This looks good to me with those fixes. (Still needs Ian's OK, though.)
>
> -cary
>

Attachment: gold_patch.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]