This is the mail archive of the
mailing list for the binutils project.
Re: [RFA/gold] Patch to workaround ARM1176 BLX(immediate) Thumb to ARM issue
- From: Doug Kwan (éæå) <dougkwan at google dot com>
- To: Matthew Gretton-Dann <matthew dot gretton-dann at arm dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>, ian at airs dot com
- Date: Mon, 26 Sep 2011 11:41:11 -0700
- Subject: Re: [RFA/gold] Patch to workaround ARM1176 BLX(immediate) Thumb to ARM issue
- References: <4E8095A3.email@example.com>
Thanks for fixing that. That patch looks okay. My only concern is
that may_use_v*t_interworking are called repeatedly and their values
are constant. Can you cache the values just like may_use_blx?
On Mon, Sep 26, 2011 at 8:09 AM, Matthew Gretton-Dann
> The attached patch adds the options --[no-]fix-arm1176 to Gold in a similar
> manner to that done to Ld earlier this year (see
> When --fix-arm1176 is turned on (the default) ARM v5T interworking
> instructions are only available for ARM v6T2 and later architectures.
> Further details on the erratum can be found on ARM's documentation website:
> ? ?http://infocenter.arm.com/
> ? ? ?User Assistance Notes
> ? ? ? ?ARM11 Processors
> ? ? ? ? ?ARM1176JZ-S and ARM1176JFZ-S Programmer Advice Note
> This patch depends on my recently posted fixes to v4T/v5T interworking in
> gold (http://sourceware.org/ml/binutils/2011-09/msg00186.html).
> Please can someone review.
> 2011-09-26 ?Matthew Gretton-Dann<firstname.lastname@example.org>
> ? ? ? ?* arm.cc (Target_arm::may_use_v5t_interworking): Check whether
> ? ? ? ?we are working around the ARM1176 Erratum.
> ? ? ? ?* options.h (General_options::fix_arm1176): Add option.
> ? ? ? ?* testsuite/Makefile.am: Add testcases, and keep current ones
> ? ? ? ?working.
> ? ? ? ?* testsuite/Makefile.in: Regenerate.
> ? ? ? ?* testsuite/arm_fix_1176.s: New file.
> ? ? ? ?* testsuite/arm_fix_1176.sh: Likewise.
> Matthew Gretton-Dann
> Principal Engineer, PD Software - Tools, ARM Ltd