This is the mail archive of the
mailing list for the binutils project.
Re: [patch bfd]: Avoid to remove leading underscore for anon-object for pe-coff targets with empty USER_LABEL_PREFIX
2011/9/9 Christopher Faylor <firstname.lastname@example.org>:
> On Fri, Sep 09, 2011 at 02:41:58PM +0200, Kai Tietz wrote:
>>this patch avoids the removal of leading underscores for pe-coff
>>targets with empty USER_LABEL_PREFIX (like x86_64-pe-coff, and arm).
>>Regression-tested for i686-w64-mingw32 and x86_64-w64-mingw32. ?Ok for apply?
> Shouldn't that testing include a non-w64 Windows target too?
>>2011-09-09 ?Kai Tietz ?<email@example.com>
>> ? ? ? ?* peicode.h (pe_ILF_build_a_bfd): Don't remove leading underscore
>> ? ? ? ?for targets without symbol_leading_char.
> It looks ok to me, but I would like confirmation that it works with
> mingw32 and Cygwin.
I tested iit for 686-w64-mingw32 target - as I wrote - and this is a
32-bit i686 target. So test is sufficiant as there is in binutils'
bfd code no difference between i686-pc-mingw32, i686-pc-cygwin, and
i686-w64.mingw32 targets in this area.