This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Properly define elf_backend_post_process_headers


On Tue, Jul 05, 2011 at 12:06:24PM -0700, H.J. Lu wrote:
> On Tue, Jul 5, 2011 at 11:21 AM, Aurelien Jarno <aurelien@aurel32.net> wrote:
> > On Sat, Jun 25, 2011 at 11:05:35AM -0700, H dot J dot ?Lu wrote:
> >> I checked in this patch to proerly define
> >> elf_backend_post_process_headers.
> >
> > This patch seems to break setting the OSABI on FreeBSD. Before this
> > patch it was ELFOSABI_FREEBSD, with this patch applied, it is changed
> > to ELFOSABI_NONE.
> >
> >> H.J.
> >> ---
> >> diff --git a/bfd/ChangeLog b/bfd/ChangeLog
> >> index b3ffc1b..58bf993 100644
> >> --- a/bfd/ChangeLog
> >> +++ b/bfd/ChangeLog
> >> @@ -1,3 +1,8 @@
> >> +2011-06-25 ?H.J. Lu ?<hongjiu.lu@intel.com>
> >> +
> >> + ? ? * elf64-x86-64.c (elf_backend_post_process_headers): Don't
> >> + ? ? define for FreeBSD/x86-64 nor FreeBSD/L1OM. ?Define for L1OM.
> >> +
> >> ?2011-06-25 ?Jan Kratochvil ?<jan.kratochvil@redhat.com>
> 
> We should always define elf_backend_post_process_headers to
> _bfd_elf_set_osabi for ELF/x86-64.  I checked in this patch.

I confirm it works, thanks for the quick fix.

Aurelien

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]