This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[vms/committed]: cleanup in gas/config/evax-obj.[ch]


Hi,

I added some comments, fixed some style issues and removed unused declaration.

Committed on trunk.

Tristan.

gas/
2011-06-27  Tristan Gingold  <gingold@adacore.com>

	* config/obj-evax.c (evax_frob_file_before_adjust): Add comments.
	Fix style.
	* config/obj-evax.h (struct alpha_linkage_fixups): Remove seg
	field.  Add comments.
	(obj_symbol_type, object_headers, OBJ_SYMFIELD_TYPE): Remove


Index: obj-evax.c
===================================================================
RCS file: /cvs/src/src/gas/config/obj-evax.c,v
retrieving revision 1.9
diff -c -r1.9 obj-evax.c
*** obj-evax.c	24 Jun 2011 15:44:41 -0000	1.9
--- obj-evax.c	27 Jun 2011 09:53:37 -0000
***************
*** 153,158 ****
--- 153,160 ----
      {
        if (S_GET_SEGMENT (l->fixp->fx_addsy) == alpha_link_section)
  	{
+           /* The symbol is defined in the file.  The linkage entry decays to
+              two relocs.  */
  	  symbolS *entry_sym;
  	  fixS *fixpentry, *fixppdesc, *fixtail;
  
***************
*** 166,172 ****
  	  fixpentry = fix_new (l->fixp->fx_frag, l->fixp->fx_where, 8,
  			       entry_sym, l->fixp->fx_offset, 0,
  			       BFD_RELOC_64);
! 	  fixppdesc = fix_new (l->fixp->fx_frag, l->fixp->fx_where+8, 8,
  			       l->fixp->fx_addsy, l->fixp->fx_offset, 0,
  			       BFD_RELOC_64);
  	  l->fixp->fx_size = 0;
--- 168,174 ----
  	  fixpentry = fix_new (l->fixp->fx_frag, l->fixp->fx_where, 8,
  			       entry_sym, l->fixp->fx_offset, 0,
  			       BFD_RELOC_64);
! 	  fixppdesc = fix_new (l->fixp->fx_frag, l->fixp->fx_where + 8, 8,
  			       l->fixp->fx_addsy, l->fixp->fx_offset, 0,
  			       BFD_RELOC_64);
  	  l->fixp->fx_size = 0;
***************
*** 184,189 ****
--- 186,192 ----
  	}
        else
  	{
+           /* Assign a linkage index.  */
  	  ((struct evax_private_udata_struct *)
  	   symbol_get_bfdsym (l->label)->udata.p)->lkindex = linkage_index;
  
Index: obj-evax.h
===================================================================
RCS file: /cvs/src/src/gas/config/obj-evax.h,v
retrieving revision 1.10
diff -c -r1.10 obj-evax.h
*** obj-evax.h	28 Jun 2010 14:06:56 -0000	1.10
--- obj-evax.h	27 Jun 2011 09:53:37 -0000
***************
*** 38,48 ****
  
  struct fix;
  
  struct alpha_linkage_fixups
  {
    struct alpha_linkage_fixups *next;
    struct fix *fixp;
!   segT seg;
    symbolS *label;
  };
  
--- 38,55 ----
  
  struct fix;
  
+ /* Simply linked list of .linkage.  */
  struct alpha_linkage_fixups
  {
+   /* Next entry.  */
    struct alpha_linkage_fixups *next;
+ 
+   /* Corresponding fixup.  */
    struct fix *fixp;
! 
!   /* Label that designates this entry.
!      Note that a linkage entry can only be designated by one label.
!      Also, s_alpha_linkage force the creation of a label.  */
    symbolS *label;
  };
  
***************
*** 60,79 ****
  
  /* #define SYMBOLS_NEED_PACKPOINTERS */
  
- /*  */
- typedef struct
-   {
-     void *nothing;
-   }
- obj_symbol_type;		/* should be the format's symbol structure */
- 
- typedef void *object_headers;
- 
  #define OBJ_EMIT_LINENO(a,b,c)	/* must be *something*.  This no-op's it out.  */
  
- /* This field keeps the symbols position in the link section.  */
- #define OBJ_SYMFIELD_TYPE valueT
- 
  #define obj_symbol_new_hook(s)       evax_symbol_new_hook (s)
  #define obj_frob_symbol(s,p)         evax_frob_symbol (s, &p)
  #define obj_frob_file_before_adjust  evax_frob_file_before_adjust
--- 67,74 ----


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]