This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[gold patch] Fix incremental linking when input files have compressed debug sections

With compressed debug sections in the input file, the linker was
storing the compressed size of the section in the incremental info
instead of the uncompressed size. This patch fixes that, and also adds
a check to disallow the use of the linker's --compress-debug-sections
option when doing incremental linking.



2011-06-09  Cary Coutant  <>

	* gold/ (queue_initial_tasks): Warn if --incremental is
	used with --compress-debug-sections.
	* gold/ (Sized_relobj_file::do_layout): Report
	uncompressed size of compressed input sections.

commit ceffdcabd8e3803341a09b6ed4205cf23f472bb1
Author: Cary Coutant <>
Date:   Thu Jun 9 10:52:04 2011 -0700

    Fix to record uncompressed sizes of compressed input sections.

diff --git a/gold/ b/gold/
index 95c226c..f68ba3e 100644
--- a/gold/
+++ b/gold/
@@ -200,6 +200,9 @@ queue_initial_tasks(const General_options& options,
 	gold_error(_("incremental linking is incompatible with --icf"));
       if (options.has_plugins())
 	gold_error(_("incremental linking is incompatible with --plugin"));
+      if (strcmp(options.compress_debug_sections(), "none") != 0)
+	gold_error(_("incremental linking is incompatible with "
+		     "--compress-debug-sections"));

       if (parameters->incremental_update())
diff --git a/gold/ b/gold/
index b14c85d..b51cbfe 100644
--- a/gold/
+++ b/gold/
@@ -1299,8 +1299,13 @@ Sized_relobj_file<size,
big_endian>::do_layout(Symbol_table* symtab,
 	      && (shdr.get_sh_type() == elfcpp::SHT_PROGBITS
 	          || shdr.get_sh_type() == elfcpp::SHT_NOBITS
 	          || shdr.get_sh_type() == elfcpp::SHT_NOTE))
-	    incremental_inputs->report_input_section(this, i, name,
-						     shdr.get_sh_size());
+	    {
+	      off_t sh_size = shdr.get_sh_size();
+	      section_size_type uncompressed_size;
+	      if (this->section_is_compressed(i, &uncompressed_size))
+		sh_size = uncompressed_size;
+	      incremental_inputs->report_input_section(this, i, name, sh_size);
+	    }

           if (discard)

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]