This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch gas] LDRD warnings for unpredictable behaviour.
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: James Greenhalgh <james dot greenhalgh at arm dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Thu, 09 Jun 2011 11:02:18 +0100
- Subject: Re: [patch gas] LDRD warnings for unpredictable behaviour.
- References: <001601cc25f0$db632b70$92298250$@greenhalgh@arm.com>
On 08/06/11 16:29, James Greenhalgh wrote:
> Apologies, I stripped the indentation changes with the previous send.
>
> James Greenhalgh
>
> ---
>
> This patch corrects the behaviour of do_ldrd to warn in
> unpredictable cases and adds associated test cases. Previous code
> checked against LOAD_BIT (mask 0x00100000) which is
> not set for the LDRD instruction. This patch checks against
> V4_STR_BIT (mask 0x00000020) to correctly distinguish between ldrd and
> strd.
>
> Tested using make check with no regression.
>
> James Greenhalgh
>
> gas/ChangeLog:
>
> 2011-05-25 James Greenhalgh <james.greenhalgh@arm.com>
>
> * config/tc-arm.c (do_ldrd): Warn in unpredictable cases.
>
> gas/testsuite/ChangeLog:
>
> 2011-05-25 James Greenhalgh <james.greenhalgh@arm.com>
>
> * gas/arm/ldrd-unpredicatble.d: New testcase.
> * gas/arm/ldrd-unpredicatble.s: Likewise.
> * gas/arm/ldrd-unpredicatble.l: Likewise.
>
>
Thanks, I've put this in.
I minor note. The final hunk (ldrd-unpredictable.s) did not apply
cleanly because the patch did not end with a new line and gnu patch
thought the hunk was thus corrupt. You might want to look at how you
generate your patches (there's a way of telling patch that the last line
doesn't have a terminator), but better still would be to ensure that
files end with a new-line marker.
R.