This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [gold patch] Incremental 13/18: Dynamic relocations
- From: Cary Coutant <ccoutant at google dot com>
- To: Ian Lance Taylor <iant at google dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Tue, 24 May 2011 14:43:51 -0700
- Subject: Re: [gold patch] Incremental 13/18: Dynamic relocations
- References: <BANLkTimP1wvUaTy8+F-32eFOS9_BKsWTJQ@mail.gmail.com> <mcrei3ojgy5.fsf@coign.corp.google.com>
> I don't mind having Sized_relobj_base when just a couple of things refer
> to it, but it looks wrong when lots of functions use it. ?The name of a
> class should indicate what sort of thing it is, rather than its position
> in the class heirarchy. ?We should consider renaming, e.g.,
> Sized_relobj_base => Sized_relobj, Sized_relobj => Sized_relobj_file,
> Sized_incr_relobj => Sized_relobj_incr. ?I'm open to other suggestions.
Done.
>> + ?// Create the rela_dyn section.
>> + ?(void)this->rela_dyn_section(layout);
>
> Drop the "(void)".
Done.
> This is OK with those changes.
Thanks, committed.
-cary