This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix BSD build regression on core file's PID


On 11.05.11 23:56, Jan Kratochvil wrote:
Hi,

my checked-in patch
	[patch] Implement core file's PID for s390* and ppc*
	http://sourceware.org/ml/binutils/2011-04/msg00272.html
=
	commit 3248de0b35901423585ea213f7d5985fe5146b38
	Author: Jan Kratochvil<jan.kratochvil@redhat.com>
	Date:   Tue May 10 06:13:05 2011 +0000
	bfd/
	* elf.c (elfcore_grok_psinfo): Initialize CORE_PID for both native and
	32bit psinfo.
	* elf32-ppc.c (ppc_elf_grok_psinfo): Initialize core_pid.
	* elf64-ppc.c (ppc64_elf_grok_psinfo): Likewise.

was reported by Andreas Tobler as breaking BSD build.

I made a straightforward implementation - or maybe BSD has psinfo.pr_who to
use instead?  I admit I haven't installed BSD for this patch.

This is the prpsinfo:


typedef struct prpsinfo {
    int         pr_version;
    size_t      pr_psinfosz;
    char        pr_fname[PRFNAMESZ+1];
    char        pr_psargs[PRARGSZ+1];
} prpsinfo_t;

I have tested the patch on my x86_64-freebsd installation and the build succeeded.

Thank you Jan!

Gruss,
Andreas


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]