This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Fix ld testcases on c6x
- From: Alan Modra <amodra at gmail dot com>
- To: Bernd Schmidt <bernds at codesourcery dot com>
- Cc: binutils at sources dot redhat dot com, Paul Brook <paul at codesourcery dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>
- Date: Wed, 11 May 2011 21:26:05 +0930
- Subject: Re: Fix ld testcases on c6x
- References: <4DCA6E9F.3030409@codesourcery.com>
On Wed, May 11, 2011 at 01:10:23PM +0200, Bernd Schmidt wrote:
> +if { ![ld_assemble $as "$as_opt $srcdir/$subdir/tbss.s" tmpdir/tbss.o ]
> + || ![ld_assemble $as "$as_opt $srcdir/$subdir/frame.s" tmpdir/frame.o] }
Passing options like this in the "source" parameter of ld_assemble
isn't the cleanest way. Better would be to twiddle ASFLAGS (See
ld-frv/tls.exp for an example). I'll OK your patch changed to use
ASFLAGS.
Best would be to add an "asflags" parameter to ld_assemble but I won't
ask for that since I probably wouldn't bother to do so myself..
Preapproved if you do care to go that route.
--
Alan Modra
Australia Development Lab, IBM