This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH,plugins,head+2.21] Fix pr12365 on COFF.
- From: Dave Korn <dave dot korn dot cygwin at gmail dot com>
- To: Dave Korn <dave dot korn dot cygwin at gmail dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Sat, 07 May 2011 15:29:12 +0100
- Subject: Re: [PATCH,plugins,head+2.21] Fix pr12365 on COFF.
- References: <4DC431C1.3050406@gmail.com> <20110507061306.GQ7018@bubble.grove.modra.org>
On 07/05/2011 07:13, Alan Modra wrote:
> On Fri, May 06, 2011 at 06:37:05PM +0100, Dave Korn wrote:
>> Tested on i686-pc-cygwin, fixes PR12365 and current failures in the
>> ld-plugin tests and HJ's lto tests except for the ones that rely on mixed IR
>> and non-IR relocatable links.
>>
>> OK for head and backport to branch in a couple of days time?
>
> OK.
>
>> + /* Complain if definition comes from a discarded section. */
>> + if (ps->flags & SEC_EXCLUDE)
>
> Strictly speaking this only tests for one class of discarded sections.
> I'm happy with the test, just the comment is a little misleading.
Reworded to "an excluded section", and applied after remembering to
reference the PR in the changelogs.
cheers,
DaveK