This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] C6X unwinding table generation #2
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Paul Brook <paul at codesourcery dot com>
- Cc: binutils at sourceware dot org
- Date: Tue, 3 May 2011 15:55:36 +0000 (UTC)
- Subject: Re: [PATCH] C6X unwinding table generation #2
- References: <201105031533.08664.paul@codesourcery.com>
On Tue, 3 May 2011, Paul Brook wrote:
> Attached is revised[1] patch to implement C6X unwinding table generation.
> I believe this and the subsequent patch address the issues raised by Joseph
> last time round.
>
> Ok?
>
> Paul
>
> [1] Original patch: http://sourceware.org/ml/binutils/2011-04/msg00097.html
>
> 2011-05-03 Paul Brook <paul@codesourcery.com>
>
>
> bfd/
> * elf32-tic6x.c (elf32_tic6x_howto_table,
[...]
This ChangeLog entry doesn't appear to correspond to the attached patch.
> + memset(unwind, 0, sizeof(*unwind));
Missing spaces before '(' twice on this line.
> + case 2: /* B regs. */
> + if (reg.num < 16)
> + return reg.num + 16;
> + else if (reg.num < 32)
> + return (reg.num - 16) + 53;
> + else
> + return -1;
> +
> + return reg.num + 16;
This final "return reg.num + 16;" is dead.
> +#define UNWIND_OP2_CANTUNWIND 0x8000
This still appears to be unused (so should be removed).
The patch is OK with those issues fixed.
--
Joseph S. Myers
joseph@codesourcery.com