This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Binutils patch to add support for Open8 MCU
On Wed, 30 Mar 2011, khays@hayshaus.com wrote:
> Please ignore the attempted submission.
I'm going ahead and not doing that.
> Would one of the moderators please give me some guidance on the BKM for
> submitting such a large patchset?
Have a look at the list archives for previous port submissions;
look at the last three and interpolate.
> I plead ignorance of the mailer's limitations (400,000 bytes per email message),
> and ask forgiveness for botching this submission.
> The patchset runs 21MB, largely due to the testsuite for gas.
Maybe some of those are due to the overlong ChangeLog entries,
where "gas/open8: New directory with test-cases." would suffice
instead of "gas/testsuite/gas/open8/adc.d: Add support for Open8
MCU" for each file, and (in bfd) "Makefile.in, bfd/archures.c:
Ditto" (comma-separated list) after the first Makefile.am: Add
support for Open8 MCU". :)
Random spotting of "#if 0" code (remove that) and the "lappend
cpus_expected open8" in objdump.expp is actually unnecessary
(only necessary where the CPU name isn't canonical as in the
first component of the tuple) IIRC.
On the plus side, kudos for actually having a gas test-suite in
the initial submission! FWIW, at least equally important to do
that for ld.
brgds, H-P