This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[RFA/gas] dwarf2dbg.c, plug some memory leaks.
- From: Michael Snyder <msnyder at vmware dot com>
- To: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Wed, 09 Mar 2011 12:51:54 -0800
- Subject: [RFA/gas] dwarf2dbg.c, plug some memory leaks.
Review?
2011-03-09 Michael Snyder <msnyder@vmware.com>
* dwarf2dbg.c (out_file_list): Free malloced 'dir'.
(out_debug_info): Free malloced 'dirname' and 'comp_dir'.
Index: dwarf2dbg.c
===================================================================
RCS file: /cvs/src/src/gas/dwarf2dbg.c,v
retrieving revision 1.108
diff -u -p -r1.108 dwarf2dbg.c
--- dwarf2dbg.c 28 Feb 2011 18:32:52 -0000 1.108
+++ dwarf2dbg.c 9 Mar 2011 20:48:30 -0000
@@ -1328,6 +1328,7 @@ out_file_list (void)
size = strlen (dir) + 1;
cp = frag_more (size);
memcpy (cp, dir, size);
+ xfree ((char *) dir);
}
/* Terminate it. */
out_byte ('\0');
@@ -1684,6 +1685,7 @@ out_debug_info (segT info_seg, segT abbr
memcpy (p, dirname, len);
INSERT_DIR_SEPARATOR (p, len);
#endif
+ xfree ((char *) dirname);
}
len = strlen (files[1].filename) + 1;
p = frag_more (len);
@@ -1694,6 +1696,7 @@ out_debug_info (segT info_seg, segT abbr
len = strlen (comp_dir) + 1;
p = frag_more (len);
memcpy (p, comp_dir, len);
+ xfree ((char *) comp_dir);
/* DW_AT_producer */
sprintf (producer, "GNU AS %s", VERSION);