This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: Mention symbol name in non-constant .size expression

From: "H.J. Lu" <hjl dot tools at gmail dot com>
To: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>, hp at axis dot com, binutils at sourceware dot org
Cc: Alan Modra <amodra at gmail dot com>
Date: Sun, 6 Mar 2011 21:43:18 -0800
Subject: Re: PATCH: Mention symbol name in non-constant .size expression
References: <AANLkTik8iLbOA9=EU-mnPn+7ZvCco+x4sdwGwRAY-pqQ@mail.gmail.com> <201103070328.p273S2rm023864@ignucius.se.axis.com> <20110307035457.GL6275@bubble.grove.modra.org>

On Sun, Mar 6, 2011 at 7:54 PM, Alan Modra <amodra@gmail.com> wrote:
> On Mon, Mar 07, 2011 at 04:28:02AM +0100, Hans-Peter Nilsson wrote:
>> If there's no intention to actually fix it, I think xfail is
>> more appropriate; no particular reason it should fail, IMHO.
>
> The new test will fail for any target without DIFF_EXPR_OK defined.
> HJ, I don't think it is worth going to the bother of firstly finding
> out exactly what set of targets that is, then xfailing them all.
> Please just revert the testsuite change that checks for the symbol
> name.
>

Done.


-- 
H.J.

References:
- Re: PATCH: Mention symbol name in non-constant .size expression
  - From: H.J. Lu
- Re: PATCH: Mention symbol name in non-constant .size expression
  - From: Hans-Peter Nilsson
- Re: PATCH: Mention symbol name in non-constant .size expression
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]