Re: [6/6] Main ARM STT_GNU_IFUNC patch

[Richard Sandiford <richard dot sandiford at linaro dot org>]

"H.J. Lu" <hjl.tools@gmail.com> writes:
> On Fri, Mar 4, 2011 at 8:32 AM, Richard Sandiford
> <richard.sandiford@linaro.org> wrote:
>> This is the main STT_GNU_IFUNC patch. ÂI'll try not to write too much
>> about it because the explanations ought to be in the code. ÂA few
>> points though:
>>
>> - The main question was how to record PLT information for local
>> Âsymbools. ÂOne way (used by x86 and x86_64) is to have a fake hash
>> Âtable entry. ÂAnother (used by PPC) is to put the PLT information in
>> Âthe local symbol information. ÂI tried both ways, but in the end I
>> Âwent for the latter. ÂIt seemed strange to have a hash table entry
>> Âwithout a symbol name (which is after all the hash key), so I wasn't
>> Âhappy about having to add !root.root.string tests when using the
>> Âformer approach. ÂIt also seemed to make things more complicated
>> Âoverall.
>>
>
> I used fake hash table to handle complex things.  You
> may want to take a look at all x86 IFUNC linker tests and
> adopt them for ARM.

It's purely a representational issue.  The complexity of the things
you can do shouldn't change either way.

ARM has its own complexities, such as the ARM vs. Thumb issue, which is
why I'd written custom tests.  I think they cover all the same things
as the ld-ifunc tests do.

Richard