This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch ld]: Testsuite fix of vers-script-3 and vers-script-4 tests


2011/2/15 Kai Tietz <ktietz70@googlemail.com>:
> Hello,
>
> ChangeLog
>
> 2011-02-15 ?Kai Tietz
>
> ? ? ? ?* ld-pe/vers-script-3.ver: Add _Z* to global and use
> ? ? ? ?wildcard for personality symbols.
> ? ? ? ?* ld-pe/vers-script-4.ver: Likewise.
>
> Tested for x86_64-w64-mingw32 and i686-w64-mingw32. Ok for apply?
>
> Regards,
> Kai
>

Ok, I withdraw recent patch. It is just fixing the symptoms but not
the underlying issue.
For 32-bit COFF the real issue is in pe-dll.c file in function
process_def_file_and_drectve. Here the underscore of a symbol is
stripped, and the same time it is done in bfd_demangle, which is used
by bfd_find_version_for_sym. By this in 32-bit case with leading
underscores, they were stripped twice.

ChangeLog

2011-02-15  Kai Tietz

          * pe-dll.c (process_def_file_and_drectve): Don't strip
          leading underscore from symbol by calling bfd_find_version_for_sym.

Tested for x86_64-w64-mingw32, i686-pc-cygwin, and i686-w64-mingw32.
Ok for apply?

Regards,
Kai

Attachment: pe_dll.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]