This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Dangling pointer in ICF from c_str method.

From: Sriraman Tallam <tmsriram at google dot com>
To: binutils <binutils at sourceware dot org>, Doug Kwan (éæå) <dougkwan at google dot com>, Ian Lance Taylor <iant at google dot com>, rguenth at gcc dot gnu dot org
Date: Wed, 2 Feb 2011 13:19:50 -0800
Subject: Dangling pointer in ICF from c_str method.

Hi,

   Doug Kwan found a bug in ICF caused by a dangling pointer from
using c_str on a temporary string object. I have attached a patch to
fix it. I suspect this as the cause of bug  reported in :
http://sourceware.org/bugzilla/show_bug.cgi?id=12388. Richard, could
you please see if this patch fixes the bug as I am unable to reproduce
it.

2011-02-02  Sriraman Tallam  <tmsriram@google.com>

	* icf.h (is_section_foldable_candidate): Change type of parameter
        to std::string.
	* icf.cc (Icf::find_identical_sections): Change type of local variable
        section_name to be std::string.
	(is_function_ctor_or_dtor): Change type of parameter to std::string.

Thanks,
-Sri.

Attachment: gold_patch.txt
Description: Text document

Follow-Ups:
- Re: Dangling pointer in ICF from c_str method.
  - From: Ian Lance Taylor
- Re: Dangling pointer in ICF from c_str method.
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]