Re: [PATCH #1] mips*-kfreebsd-gnu support in BFD

[Richard Sandiford <rdsandiford at googlemail dot com>]

Hi Robert,

I was in the process of applying your patches, and noticed that the
config.bfd entry doesn't look quite right.

Robert Millan <rmh@gnu.org> writes:
> @@ -1015,6 +1015,16 @@ case "${targ}" in
>      targ_selvecs="bfd_elf32_tradlittlemips_vec ecoff_big_vec ecoff_little_vec bfd_elf32_ntradbigmips_vec bfd_elf64_tradbigmips_vec bfd_elf32_ntradlittlemips_vec bfd_elf64_tradlittlemips_vec"
>      want64=true
>      ;;
> +  mips*el-*-freebsd* | mips*el-*-kfreebsd*-gnu)
> +    targ_defvec=bfd_elf32_tradlittlemips_freebsd_vec
> +    targ_selvecs="bfd_elf32_ntradlittlemips_vec bfd_elf32_ntradbigmips_vec bfd_elf32_ntradlittlemips_vec bfd_elf32_tradbigmips_vec bfd_elf64_tradlittlemips_vec bfd_elf64_tradbigmips_vec bfd_elf32_ntradbigmips_freebsd_vec bfd_elf32_tradlittlemips_freebsd_vec bfd_elf32_tradbigmips_freebsd_vec bfd_elf64_tradlittlemips_freebsd_vec bfd_elf64_tradbigmips_freebsd_vec"
> +    want64=true

Here you've got bfd_elf32_ntradlittlemips_vec twice (first and third),
no bfd_elf32_tradlittlemips_vec, and no bfd_elf32_ntradlittlemips_freebsd_vec.
Same sort of problems for the big-endian case.  This leads to a lot of errors
when running the testsuite for mips64-unknown-kfreebsd-gnu

Also, your GAS patch says that N32 is the default for mips64,
but there's no corresponding config.bfd entry that sets
bfd_elf32_ntrad*mips_freebsd_vec to be the default for
mips64*-kfreebsd-gnu.

Sorry for not picking up on this first time round.

Richard