This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 08/20] MIPS/GAS: Improve a LUI complaint message
On Sun, 5 Dec 2010, Hans-Peter Nilsson wrote:
> Just a bikeshed comment from the sideline: The [] in changelog-
> entries is canonically for conditionally defined stuff; within
> #ifdef X/#if X. For case statements, the canonical marking is
> <case X> or <X>, like:
>
> * config/tc-mips.c (mips_ip) <case 'u'>: Report the value of the LUI
> or
> * config/tc-mips.c (mips_ip) <'u'>: Report the value of the LUI
>
> Feel free to ignore this, I just don't want your format to catch
> on - and possibly be forced to use it. ;)
Sorry for the late response -- thanks for the hint and as you may have
noticed I did take it into account. I feel no reason to diverge from the
established practice merely because I missed some of its details.
Maciej