This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 08/20] MIPS/GAS: Improve a LUI complaint message

From: "Maciej W. Rozycki" <macro at codesourcery dot com>
To: Hans-Peter Nilsson <hp at bitrange dot com>
Cc: binutils at sourceware dot org
Date: Sun, 19 Dec 2010 00:58:31 +0000 (GMT)
Subject: Re: [PATCH 08/20] MIPS/GAS: Improve a LUI complaint message
References: <alpine.DEB.1.10.1012020105230.14129@tp.orcam.me.uk> <alpine.BSF.2.00.1012052029380.70303@dair.pair.com>

On Sun, 5 Dec 2010, Hans-Peter Nilsson wrote:

> Just a bikeshed comment from the sideline: The [] in changelog-
> entries is canonically for conditionally defined stuff; within
> #ifdef X/#if X.  For case statements, the canonical marking is
> <case X> or <X>, like:
> 
> 	* config/tc-mips.c (mips_ip) <case 'u'>: Report the value of the LUI
> or
> 	* config/tc-mips.c (mips_ip) <'u'>: Report the value of the LUI
> 
> Feel free to ignore this, I just don't want your format to catch
> on - and possibly be forced to use it. ;)

 Sorry for the late response -- thanks for the hint and as you may have 
noticed I did take it into account.  I feel no reason to diverge from the 
established practice merely because I missed some of its details.

  Maciej

References:
- [PATCH 08/20] MIPS/GAS: Improve a LUI complaint message
  - From: Maciej W. Rozycki
- Re: [PATCH 08/20] MIPS/GAS: Improve a LUI complaint message
  - From: Hans-Peter Nilsson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]