This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH #1] mips*-kfreebsd-gnu support in BFD
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: Robert Millan <rmh at gnu dot org>
- Cc: binutils at sourceware dot org
- Date: Sat, 18 Dec 2010 10:25:51 +0000
- Subject: Re: [PATCH #1] mips*-kfreebsd-gnu support in BFD
- References: <1292259049.699.0@thorin> <1292341157.29336.0@thorin>
Robert Millan <rmh@gnu.org> writes:
> Please consider this new version which also includes support
> for FreeBSD.
OK to apply, thanks. It's a very minor detail, but for the record...
> Index: bfd/configure.host
> ===================================================================
> RCS file: /cvs/src/src/bfd/configure.host,v
> retrieving revision 1.18
> diff -u -p -r1.18 configure.host
> --- bfd/configure.host 15 Feb 2010 19:25:47 -0000 1.18
> +++ bfd/configure.host 8 Dec 2010 20:24:09 -0000
> @@ -50,6 +50,7 @@ mips*-sgi-irix3*) HDEFINES="-G 4" ;;
> mips*-sgi-irix4*) HDEFINES="-G 4" ;;
> mips*-sgi-irix6*) host64=true;;
> mips64*-*-linux*) host64=true;;
> +mips64*-*-freebsd* | mips64*-*-kfreebsd*-gnu) host64=true;;
> mips*-*-sysv4*) ;;
> mips*-*-sysv*) HDEFINES="-G 4" ;;
> mips*-*-riscos*) HDEFINES="-G 4" ;;
...it looks like the prevailing idiom is to have one case per line,
so I wondered about asking you to change that. However...
> Index: bfd/configure.in
> ===================================================================
> RCS file: /cvs/src/src/bfd/configure.in,v
> retrieving revision 1.288
> diff -u -p -r1.288 configure.in
> --- bfd/configure.in 5 Nov 2010 08:58:20 -0000 1.288
> +++ bfd/configure.in 8 Dec 2010 20:24:12 -0000
> @@ -748,8 +748,10 @@ do
> bfd_elf32_msp430_vec) tb="$tb elf32-msp430.lo elf32.lo $elf" ;;
> bfd_elf32_nbigmips_vec) tb="$tb elfn32-mips.lo elfxx-mips.lo elf-vxworks.lo elf32.lo $elf ecofflink.lo"; target_size=64 ;;
> bfd_elf32_nlittlemips_vec) tb="$tb elfn32-mips.lo elfxx-mips.lo elf-vxworks.lo elf32.lo $elf ecofflink.lo"; target_size=64 ;;
> - bfd_elf32_ntradbigmips_vec) tb="$tb elfn32-mips.lo elfxx-mips.lo elf-vxworks.lo elf32.lo $elf ecofflink.lo"; target_size=64 ;;
> - bfd_elf32_ntradlittlemips_vec) tb="$tb elfn32-mips.lo elfxx-mips.lo elf-vxworks.lo elf32.lo $elf ecofflink.lo"; target_size=64 ;;
> + bfd_elf32_ntradbigmips_vec | bfd_elf32_ntradbigmips_freebsd_vec)
> + tb="$tb elfn32-mips.lo elfxx-mips.lo elf-vxworks.lo elf32.lo $elf ecofflink.lo"; target_size=64 ;;
> + bfd_elf32_ntradlittlemips_vec | bfd_elf32_ntradlittlemips_freebsd_vec)
> + tb="$tb elfn32-mips.lo elfxx-mips.lo elf-vxworks.lo elf32.lo $elf ecofflink.lo"; target_size=64 ;;
...the same is really true here, and it's led to horrible cut-&-paste.
With all these duplicated lists, it's pain to update when you add a new
object dependency. So, I agree what you've done here is the right thing,
and so we might as well do the same in configure.host.
Richard