This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH 17/20] MIPS/GAS: Remove XLR MSG* macro special return points
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: Richard Sandiford <rdsandiford at googlemail dot com>
- Cc: Catherine Moore <clm at codesourcery dot com>, binutils at sourceware dot org
- Date: Thu, 2 Dec 2010 19:23:12 +0000 (GMT)
- Subject: [PATCH 17/20] MIPS/GAS: Remove XLR MSG* macro special return points
Hi,
There's no need to have dedicated return points from macro() for XLR MSG*
macros. All the other macros fall through to the single exit point at the
end of the function, so let's keep things consistent for long-term
maintenance's sake.
2010-12-02 Maciej W. Rozycki <macro@codesourcery.com>
gas/
* config/tc-mips.c (macro)
[M_MSGSND, M_MSGLD, M_MSGLD_T, M_MSGWAIT, M_MSGWAIT_T]: Remove
dedicated return points.
OK to apply?
Maciej
binutils-gas-mips-msg.diff
Index: binutils-fsf-trunk-quilt/gas/config/tc-mips.c
===================================================================
--- binutils-fsf-trunk-quilt.orig/gas/config/tc-mips.c 2010-12-01 21:05:58.000000000 +0000
+++ binutils-fsf-trunk-quilt/gas/config/tc-mips.c 2010-12-01 21:05:58.000000000 +0000
@@ -6150,37 +6150,32 @@ macro (struct mips_cl_insn *ip)
unsigned long temp = (treg << 16) | (0x01);
macro_build (NULL, "c2", "C", temp);
}
- /* AT is not used, just return */
- return;
+ break;
case M_MSGLD:
{
unsigned long temp = (0x02);
macro_build (NULL, "c2", "C", temp);
}
- /* AT is not used, just return */
- return;
+ break;
case M_MSGLD_T:
{
unsigned long temp = (treg << 16) | (0x02);
macro_build (NULL, "c2", "C", temp);
}
- /* AT is not used, just return */
- return;
+ break;
case M_MSGWAIT:
macro_build (NULL, "c2", "C", 3);
- /* AT is not used, just return */
- return;
+ break;
case M_MSGWAIT_T:
{
unsigned long temp = (treg << 16) | 0x03;
macro_build (NULL, "c2", "C", temp);
}
- /* AT is not used, just return */
- return;
+ break;
case M_J_A:
/* The j instruction may not be used in PIC code, since it