This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2.5/4 v2] GAS: Make new fake labels when cloning a symbol


On Wed, 2010-12-01 at 21:34 +0000, Maciej W. Rozycki wrote:
> On Mon, 1 Nov 2010, Richard Sandiford wrote:
> 
> > Sounds good, but please don't let it get in the way of applying this patch
> > (when the time comes).  The change above seems entirely in keeping with
> > the way that abs_symbol is initialised.
> 
>  This is the version I applied.
> 
> 2010-12-01  Maciej W. Rozycki  <macro@codesourcery.com>
> 
> 	* symbols.h (dot_symbol): New declaration.
> 	(dot_symbol_init): New prototype.
> 	* symbols.c (dot_symbol): New variable.
> 	(symbol_clone): Assert it's not dot_symbol being cloned.
> 	(dot_symbol_init): New function.
> 	(symbol_clone_if_forward_ref): Create a new temporary symbol
> 	when trying to clone dot_symbol.
> 	* expr.c (current_location): Refer to dot_symbol instead of
> 	making a new temporary symbol.
> 	* read.c (read_a_source_file): Update dot_symbol as we go.
> 	* as.c (main): Call dot_symbol_init.

So I'm not entirely sure that this patch is responsible, but it does
look a likely candidate...

	.section	.text._ZnajPv,"axG",%progbits,_ZnajPv,comdat
	.fnstart
	.fnend

/arm/scratch/rearnsha/gnu/gcc-results/trunk/gcc/../gas/as-new
-o /tmp/x.o test.s
test.s: Assembler messages:
test.s:3: Error: redefined symbol cannot be used on reloc
/arm/scratch/rearnsha/gnu/gcc-results/trunk/gcc/../gas/as-new: /tmp/x.o:
symbol `.' required but not present
test.s:3: Fatal error: can't close /tmp/x.o: No symbols

This is on arm-eabi.

R



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]