This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] fix readelf's display of ARM unwind section
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Zach Welch <zwelch at codesourcery dot com>
- Cc: binutils at sourceware dot org
- Date: Thu, 02 Dec 2010 10:15:30 +0000
- Subject: Re: [PATCH] fix readelf's display of ARM unwind section
- References: <4CF57087.3030400@codesourcery.com>
On Tue, 2010-11-30 at 13:45 -0800, Zach Welch wrote:
> This patch fixes a minor display bug in readelf when dumping ARM unwind
> sections, printing a comma missing from a list of registers.
>
> Index: binutils-trunk/binutils/readelf.c
> ===================================================================
> --- binutils-trunk/binutils/readelf.c (revision 307746)
> +++ binutils-trunk/binutils/readelf.c (working copy)
> @@ -6542,7 +6542,7 @@ decode_arm_unwind (struct arm_unw_aux_info *aux,
> }
> if (op & 0x08)
> {
> - if (first)
> + if (!first)
> printf (", ");
> printf ("r14");
> }
>
OK.
In future please submit a ChangeLog entry along with your patch, or it
will be rejected as incomplete.
R.